8000 Update VirtualServer template to generate an internal jwt auth location per policy applied by shaun-nx · Pull Request #3798 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update VirtualServer template to generate an internal jwt auth location per policy applied #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 2, 2023
Merged

Update VirtualServer template to generate an internal jwt auth location per policy applied #3798

merged 11 commits into from
May 2, 2023

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Apr 19, 2023 •
edited
Loading

Proposed changes

This change:

  • Ensures only one proxy_cache_path is generated per VirtualServer
  • Ensures each internal jwt auth location references the proxy_cache_path of its VirtualServer
  • Ensures VirutalServer paths (e.g. /tea/leaf or /coffee/beans) will proxy_pass to a specific internal jwt auth location based on the policy applied to that route (i.e. locations will no longer create nested internal jwt auth locations)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner April 19, 2023 13:27
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests labels Apr 19, 2023
@codecov
Copy link
codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Merging #3798 (f9d1a9f) into main (28eee73) will increase coverage by 0.00%.
The diff coverage is 55.17%.

@@           Coverage Diff           @@
##             main    #3798   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          59       59           
  Lines       16902    16931   +29     
=======================================
+ Hits         8855     8871   +16     
- Misses       7750     7761   +11     
- Partials      297      299    +2
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/configs/virtualserver.go 94.54% <55.17%> (-0.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx self-assigned this Apr 25, 2023
@shaun-nx shaun-nx added this to the v3.1.1 milestone Apr 26, 2023
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 26, 2023
@lucacome lucacome merged commit dc4c543 into main May 2, 2023
@lucacome lucacome deleted the feat/jwks-subrequest-server branch May 2, 2023 22:20
lucacome pushed a commit that referenced this pull request May 4, 2023
@shaun-nx @vepatel @lucacome
Update VirtualServer template to generate an internal jwt auth locati…
959eab2 
…on per policy applied (#3798)

Co-authored-by: Venktesh <ve.patel@f5.com>
(cherry picked from commit dc4c543)
lucacome added a commit that referenced this pull request May 4, 2023
@lucacome @shaun-nx
Update VirtualServer template to generate an internal jwt auth locati…
a344511 
…on per policy applied (#3798) (#3855)

Co-authored-by: Venktesh <ve.patel@f5.com>
(cherry picked from commit dc4c543)

Co-authored-by: Shaun <s.odonovan@f5.com>
@lucacome lucacome added bug An issue reporting a potential bug and removed enhancement Pull requests for new features/feature enhancements labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@lucacome lucacome Awaiting requested review from lucacome

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assig 5CE6 nees

@shaun-nx shaun-nx

Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation tests Pull requests that update tests
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@shaun-nx @haywoodsh @ciarams87 @vepatel @jjngx @lucacome
0