8000 chore: Add new label and metadata to pod by ciarams87 · Pull Request #3586 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

chore: Add new label and metadata to pod #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

chore: Add new label and metadata to pod #3586

merged 1 commit into from
Feb 28, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

  • Add version metadata to a pod in the form of annotations
  • Add new static label to pods for filtering all NIC pods in a cluster

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@ciarams87 ciarams87 requested a review from a team as a code owner February 23, 2023 16:19
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Feb 23, 2023
@codecov-commenter
Copy link
codecov-commenter commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #3586 (203fd39) into main (37b1fd0) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head 203fd39 differs from pull request most recent head a22bfe5. Consider uploading reports for the commit a22bfe5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   52.32%   52.22%   -0.10%     
==========================================
  Files          59       59              
  Lines       16849    16873      +24     
==========================================
- Hits         8816     8812       -4     
- Misses       7738     7764      +26     
- Partials      295      297       +2
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/k8s/configuration.go 95.43% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lucacome
lucacome reviewed Feb 23, 2023
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

I left some comments. also we need to update the rbac.yaml for helm too.

@ciarams87 ciarams87 force-pushed the update-for-cluster-connector branch 4 times, most recently from d888a6b to a22bfe5 Compare February 27, 2023 16:40
jjngx
jjngx approved these changes Feb 27, 2023
View reviewed changes 8000
@ciarams87 ciarams87 force-pushed the update-for-cluster-connector branch from a22bfe5 to 00cc749 Compare February 28, 2023 10:00
@ciarams87 ciarams87 enabled auto-merge (squash) February 28, 2023 10:00
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Feb 28, 2023
@ciarams87 ciarams87 merged commit 4fb6a28 into main Feb 28, 2023
@ciarams87 ciarams87 deleted the update-for-cluster-connector branch February 28, 2023 10:08
@MaxMood96 MaxMood96 mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@vepatel vepatel Awaiting requested review from vepatel

2 more reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @codecov-commenter @lucacome @jjngx
0