8000 Support empty path for ImplementationSpecific pathType by ciarams87 · Pull Request #3507 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Support empty path for ImplementationSpecific pathType #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Support empty path for ImplementationSpecific pathType #3507

merged 1 commit into from
Feb 1, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Path is required for Exact and Prefix PathTypes, but should not be required for ImplementationSpecific PathTypes according to the Kubernetes specs

Our validation rules require a path be set for all PathTypes. This commit closes this gap - If an Ingress is configured with an ImplementationSpecific PathType and an empty Path, this will be allowed, and the Path will default to /. Otherwise ImplementationSpecific PathType is treated identically to the Prefix PathType.

Closes #3498

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner January 31, 2023 14:04
@ciarams87 ciarams87 force-pushed the feat/support-empty-path-ingress branch from 4e2e1c2 to 18a12e1 Compare January 31, 2023 14:04
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests labels Jan 31, 2023
@lucacome lucacome requested a review from a team January 31, 2023 17:37
lucacome
lucacome reviewed Jan 31, 2023
View reviewed changes
@ciarams87 ciarams87 force-pushed the feat/support-empty-path-ingress branch from 18a12e1 to 5f66c78 Compare February 1, 2023 10:31
@ciarams87 ciarams87 enabled auto-merge (squash) February 1, 2023 10:34
@ciarams87 ciarams87 merged commit 54ab48c into main Feb 1, 2023
@ciarams87 ciarams87 deleted the feat/support-empty-path-ingress branch February 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucacome lucacome lucacome approved these changes

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non standard Ingress path requirement for pathType: ImplementationSpecific breaks k8s compatibility (and 3rd party services)
3 participants
@ciarams87 @lucacome @jasonwilliams14
0