Move logic for -enable-leader-election flag in helm templates
#3475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-enable-leader-election flag in helm templates
Codecov Report
@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
+ Coverage 51.95% 51.99% +0.04%
==========================================
Files 60 60
Lines 16797 16811 +14
==========================================
+ Hits 8727 8741 +14
Misses 7775 7775
Partials 295 295
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ciarams87
reviewed
Jan 24, 2023
ciarams87
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Need to modify deployments/helm-chart/templates/controller-leader-election-configmap.yaml as well so that file is only created when the leader election is set to true.
e.g.
{{- if .Values.controller.reportIngressStatus.enableLeaderElection }}
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "nginx-ingress.leaderElectionName" . }}
namespace: {{ .Release.Namespace }}
labels:
{{- include "nginx-ingress.labels" . | nindent 4 }}
{{- if .Values.controller.reportIngressStatus.annotations }}
annotations:
{{ toYaml .Values.controller.reportIngressStatus.annotations | indent 4 }}
{{- end }}
{{- end }}
vepatel
approved these changes
Jan 24, 2023
ciarams87
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change ensures the
-enable-leader-electionflag it set tofalsewhencontroller.reportIngressStatus.enableis set to false.Closes #3455
Checklist
Before creating a PR, run through this checklist and mark each as complete.