8000 Support non-vs created Challenge Ingress by ciarams87 · Pull Request #3463 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Support non-vs created Challenge Ingress #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

Support non-vs created Challenge Ingress #3463

merged 1 commit into from
Jan 20, 2023

Conversation

ciarams87
Copy link
Contributor
@ciarams87 ciarams87 commented Jan 20, 2023 •
edited
Loading

Proposed changes

Currently, if the VS cert-manager integration is enabled (using the command line argument on start-up), Challenge Ingress resources created independantly of a VS configuration will be ignored (unless they are minion resources).

This commit rectifies the issue.

Closes #3450

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner January 20, 2023 13:38
@ciarams87 ciarams87 added the bug An issue reporting a potential bug label Jan 20, 2023
@hahahannes hahahannes mentioned this pull request Jan 20, 2023
Closed
@ciarams87 ciarams87 merged commit 241e7a3 into main Jan 20, 2023
@ciarams87 ciarams87 deleted the support-cm-challenge-no-vs-or-ingress branch January 20, 2023 15:12
@hahahannes
Copy link

@shaun-nx
Thanks a lot for the quick fix!
Is there a timeline when this will be released ? And will version 2 also get patched?

@shaun-nx
Copy link
Contributor

@hahahannes we haven't discussed a timeline for when this fix will be released yet. We'll make sure to update you when we've made a decision 😁

@hahahannes
Copy link

Alright! Thank you very much!

lucacome pushed a commit that referenced this pull request Jan 25, 2023
@ciarams87 @lucacome
Support non-vs created Challenge Ingress (#3463)
1cbe236 
(cherry picked from commit 241e7a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

2 more reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 on ACME challenge because of missing Ingress rules
4 participants
@ciarams87 @hahahannes @shaun-nx @jjngx
0