feat: Add initial support for SSL termination for TransportServer #3462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc1bd9b to
aa8f68c
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3462 +/- ##
==========================================
+ Coverage 52.17% 52.25% +0.08%
==========================================
Files 59 59
Lines 16772 16834 +62
==========================================
+ Hits 8750 8797 +47
- Misses 7727 7740 +13
- Partials 295 297 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d8c03af to
91c1740
Compare
91c1740 to
0d2c233
Compare
0d2c233 to
a1962c7
Compare
a1962c7 to
e59ba83
Compare
vepatel
approved these changes
Feb 15, 2023
e59ba83 to
738d784
Compare
880ea6b to
6ee37c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add initial support for SSL termination for TransportServer. Note this PR supports TLS termination on multiple ports, where each application owns a dedicated port: the Ingress Controller terminates TLS connections on each port, where each application uses its own cert/key, and routes connections to appropriate application (service) based on that incoming port (any TLS connection regardless of the SNI on a port will be routed to the application that corresponds to that port). Future work will include support for routing TCP connections to an appropriate application (service) based on the SNI of the connection.
Checklist
Before creating a PR, run through this checklist and mark each as complete.