8000 feat: Enable keepalive-time for healthchecks in VS and VSR by ciarams87 · Pull Request #3451 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

feat: Enable keepalive-time for healthchecks in VS and VSR #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

feat: Enable keepalive-time for healthchecks in VS and VSR #3451

merged 1 commit into from
Jan 24, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Keepalive connections for health checks – The new keepalive_time parameter to the HTTP health_check directive enables keepalive connections for health checks and sets their lifetime. Establishing new connections is computationally expensive, so reusing connections can reduce CPU usage considerably when there are large numbers of upstream servers.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner January 18, 2023 12:45
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests labels Jan 18, 2023
@ciarams87 ciarams87 force-pushed the feat/keepalive-healthcheck branch from 7a5424d to 8f5d4fb Compare January 19, 2023 10:37
@ciarams87 ciarams87 force-pushed the feat/keepalive-healthcheck branch from 8f5d4fb to c649fea Compare January 19, 2023 15:27
@ciarams87 ciarams87 force-pushed the feat/keepalive-healthcheck branch from c649fea to 9443b22 Compare January 20, 2023 10:25
jasonwilliams14
jasonwilliams14 reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor
@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. We can set a default between 30-60 seconds.
we can also give customers to disable entirely if they choose to.
it is a great new feature that will improve performance and HC effectiveness.

@ciarams87 ciarams87 force-pushed the feat/keepalive-healthcheck branch from 9443b22 to d5209b6 Compare January 23, 2023 10:55
ciarams87 force-pushed the feat/keepalive-healthcheck branch from d5209b6 to 718fa42 Compare January 24, 2023 09:06
@codecov-commenter
Copy link

Codecov Report

Merging #3451 (718fa42) into main (f135169) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
+ Coverage   51.95%   51.99%   +0.03%     
==========================================
  Files          60       60              
  Lines       16806    16811       +5     
==========================================
+ Hits         8732     8741       +9     
+ Misses       7777     7775       -2     
+ Partials      297      295       -2
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/configs/virtualserver.go 95.07% <100.00%> (+0.01%) ⬆️
pkg/apis/configuration/validation/virtualserver.go 94.39% <100.00%> (+<0.01%) ⬆️
internal/k8s/configuration.go 95.79% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 merged commit 7c117ec into main Jan 24, 2023
@ciarams87 ciarams87 deleted the feat/keepalive-healthcheck branch January 24, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@brianehlert brianehlert Awaiting requested review from brianehlert

3 more reviewers

@jasonwilliams14 jasonwilliams14 jasonwilliams14 left review comments

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ciarams87 @codecov-commenter @jasonwilliams14 @jjngx @shaun-nx
0