8000 Correct values.schema.json nodeSelector by coolbry95 · Pull Request #3449 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Correct values.schema.json nodeSelector #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Correct values.schema.json nodeSelector #3449

merged 1 commit into from
Jan 18, 2023

Conversation

coolbry95
Copy link
Contributor
@coolbry95 coolbry95 commented Jan 18, 2023 •
edited
Loading

Proposed changes

Fix the nodeSelector $ref

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@coolbry95 coolbry95 requested a review from a team as a code owner January 18, 2023 01:52
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Jan 18, 2023
lucacome
lucacome approved these changes Jan 18, 2023
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #3449 (0385273) into main (e439f67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3449   +/-   ##
=======================================
  Coverage   51.95%   51.95%           
=======================================
  Files          60       60           
  Lines       16797    16797           
=======================================
  Hits         8727     8727           
  Misses       7775     7775           
  Partials      295      295

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 3b98ef8 into nginx:main Jan 18, 2023
lucacome pushed a commit that referenced this pull request Jan 25, 2023
@coolbry95 @lucacome
Correct values.schema.json nodeSelector (#3449)
6f77fde 
(cherry picked from commit 3b98ef8)
@coolbry95 coolbry95 mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@jjngx jjngx Awaiting requested review from jjngx jjngx was automatically assigned from nginxinc/kic

2 more reviewers

@lucacome lucacome lucacome approved these changes

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coolbry95 @codecov-commenter @lucacome @jasonwilliams14
0