NSM OSS integration #3376
Merged
NSM OSS integration #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for N+ was limiting the integration of NGINX Ingress Controller and NGINX Service Mesh.
Using values-nsm was overriding unnecessary values and limiting the NIC and NSM integration.
vepatel
approved these changes
Dec 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 51.56% 51.55% -0.02%
==========================================
Files 60 60
Lines 16678 16675 -3
==========================================
- Hits 8600 8596 -4
+ Misses 7788 7787 -1
- Partials 290 292 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, OSS NIC does not integrate with NGINX Service Mesh. Before it can we must disable the NGINX+ version check preventing OSS NIC from operating with Service Mesh.
Checklist
Before creating a PR, run through this checklist and mark each as complete.