8000 Add healthcheck for transport server by jjngx · Pull Request #3361 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented Dec 12, 2022

Proposed changes

This PR is a 2nd PR that provides the Service Insight (aka Deep Healthcheck) functionality.
It adds a new probe endpoint for checking health of transport servers:

:9114/probe/ts/{name}

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements labels Dec 12, 2022
@codecov-commenter
Copy link
codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #3361 (fc9a3a0) into main (09364eb) will increase coverage by 0.24%.
The diff coverage is 79.56%.

@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
+ Coverage   51.58%   51.83%   +0.24%     
==========================================
  Files          60       60              
  Lines       16675    16747      +72     
==========================================
+ Hits         8602     8681      +79     
+ Misses       7783     7772      -11     
- Partials      290      294       +4     
Impacted Files Coverage Δ
internal/configs/virtualserver.go 95.21% <ø> (-0.02%) ⬇️
internal/healthcheck/healthcheck.go 63.63% <71.92%> (+1.73%) ⬆️
internal/configs/configurator.go 38.67% <90.62%> (+3.51%) ⬆️
internal/configs/transportserver.go 97.53% <100.00%> (+0.04%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This update includes information about healthcheck monitoring of Transport Servers. It provides info about additional probe path used for Transport Servers
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 13, 2022
@jjngx jjngx marked this pull request as ready for review December 13, 2022 12:35
@jjngx jjngx requested a review from a team as a code owner December 13, 2022 12:35
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 13, 2022
@tomasohaodha
Copy link
Contributor

As a new feature, with associated new docs requirements, I would like to make sure @ADubhlaoich reviews and gives feedback here.

@jjngx jjngx merged commit a29f7c9 into main Jan 4, 2023
@jjngx jjngx deleted the feat/service-insight-transport-server branch January 4, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0