8000 Import JWKS from URL on JWT policy by haywoodsh · Pull Request #3347 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Import JWKS from URL on JWT policy #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Jan 11, 2023
Merged

Import JWKS from URL on JWT policy #3347

merged 48 commits into from
Jan 11, 2023
+641 −34

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Dec 8, 2022 •
edited by vepatel
Loading

Proposed changes

  • Allows importing the JWKs for JWT policy by fetching them from a remote URL and store it in the cache.
  • Added appropriate web docs and readme with an example.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Dec 8, 2022
shaun-nx
shaun-nx reviewed Dec 12, 2022
View reviewed changes
@github-actions github-actions bot added documentation Pull requests/issues for documentation tests Pull requests that update tests labels Dec 13, 2022
@shaun-nx shaun-nx self-requested a review December 14, 2022 10:24
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Dec 14, 2022
@codecov-commenter
Copy link
codecov-commenter commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #3347 (6bb0424) into main (1396149) will decrease coverage by 0.63%.
The diff coverage is 26.46%.

@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   52.56%   51.92%   -0.64%     
==========================================
  Files          59       60       +1     
  Lines       16080    16781     +701     
==========================================
+ Hits         8452     8714     +262     
- Misses       7351     7773     +422     
- Partials      277      294      +17
Impacted Files Coverage Δ
cmd/nginx-ingress/flags.go 30.28% <0.00%> (-4.14%) ⬇️
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
cmd/nginx-ingress/utils.go 0.00% <0.00%> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/handlers.go 6.49% <0.00%> (-0.34%) ⬇️
internal/k8s/spiffe.go 0.00% <ø> (ø)
internal/k8s/task_queue.go 0.00% <0.00%> (ø)
internal/k8s/utils.go 14.08% <0.00%> (-0.63%) ⬇️
internal/nginx/manager.go 0.00% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jasonwilliams14
jasonwilliams14 reviewed Jan 6, 2023
View reviewed changes
lucacome
lucacome previously requested changes Jan 10, 2023
View reviewed changes
@shaun-nx shaun-nx requested a review from lucacome January 10, 2023 18:18
lucacome
lucacome reviewed Jan 10, 2023
View reviewed changes
jjngx
jjngx approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

lucacome
lucacome reviewed Jan 10, 2023
View reviewed changes
lucacome
lucacome reviewed Jan 10, 2023
View reviewed changes
jasonwilliams14
jasonwilliams14 reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor
@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment regarding the subrequest item

@shaun-nx shaun-nx dismissed lucacome’s stale review January 11, 2023 10:07

Comments will be addressed in future PRs

@shaun-nx shaun-nx merged commit 0aca31e into main Jan 11, 2023
@shaun-nx shaun-nx deleted the feat/jwks-uri branch January 11, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@pleshakov pleshakov Awaiting requested review from pleshakov

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

+3 more reviewers

@lucacome lucacome lucacome left review comments

@jasonwilliams14 jasonwilliams14 jasonwilliams14 left review comments

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@haywoodsh @codecov-commenter @vepatel @lucacome @ADubhlaoich @ciarams87 @jasonwilliams14 @jjngx @shaun-nx @JTorreG
0