8000 Accept proxy protocol when TLS passthrough enabled by haywoodsh · Pull Request #2993 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Accept proxy protocol when TLS passthrough enabled #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 5, 2022
Merged

Accept proxy protocol when TLS passthrough enabled #2993

merged 10 commits into from
Sep 5, 2022

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Aug 31, 2022 •
edited
Loading

Proposed changes

Accept requests with proxy protocol header at port 443 when TLS Passthrough is enabled to retrieve client IP.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Aug 31, 2022
@codecov-commenter
Copy link
codecov-commenter commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #2993 (8212284) into main (f541ddb) will decrease coverage by 0.72%.
The diff coverage is 16.34%.

@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
- Coverage   53.01%   52.28%   -0.73%     
==========================================
  Files          58       58              
  Lines       15645    15997     +352     
==========================================
+ Hits         8294     8364      +70     
- Misses       7072     7354     +282     
  Partials      279      279
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/configurator.go 37.38% <0.00%> (-0.08%) ⬇️
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/externaldns/controller.go 0.00% <0.00%> (ø)
internal/k8s/leader.go 0.00% <0.00%> (ø)
internal/k8s/controller.go 11.11% <4.44%> (-0.60%) ⬇️
internal/k8s/status.go 33.27% <23.63%> (-0.97%) ⬇️
internal/certmanager/cm_controller.go 18.04% <40.00%> (-0.76%) ⬇️
internal/externaldns/sync.go 36.95% <66.66%> (+0.64%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh force-pushed the feature/accept-proxy-protocol-when-tls-passthrough-enabled branch from e4c0d6c to 34879fc Compare August 31, 2022 13:45
@haywoodsh haywoodsh marked this pull request as ready for review September 5, 2022 13:46
@haywoodsh haywoodsh force-pushed the feature/accept-proxy-protocol-when-tls-passthrough-enabled branch from db9280b to 8212284 Compare September 5, 2022 23:09
@haywoodsh haywoodsh merged commit 1824435 into main Sep 5, 2022
@haywoodsh haywoodsh deleted the feature/accept-proxy-protocol-when-tls-passthrough-enabled branch September 5, 2022 23:38
@brianehlert brianehlert linked an issue Oct 11, 2022 that may be closed by this pull request
Directive duplicate if tls-passthrough is enabled when using with F5 Big-IP. #2721
Closed
@jasonwilliams14 jasonwilliams14 mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@jjngx jjngx Awaiting requested review from jjngx

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directive duplicate if tls-passthrough is enabled when using with F5 Big-IP.
4 participants
@haywoodsh @codecov-commenter @ciarams87 @vepatel
0