8000 Allow to specify image with digest in helm chart by hafe · Pull Request #2979 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Allow to specify image with digest in helm chart #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2022
Merged

Allow to specify image with digest in helm chart #2979

merged 1 commit into from
Sep 10, 2022

Conversation

hafe
Copy link
Contributor
@hafe hafe commented Aug 29, 2022

Closes #2978

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Are there tests for the helm chart?

@lucacome lucacome requested review from a team, lucacome, haywoodsh and ciarams87 August 30, 2022 21:28
@codecov-commenter
Copy link

Codecov Report

Merging #2979 (1954e64) into main (c6eac4d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   52.31%   52.30%   -0.02%     
==========================================
  Files          58       58              
  Lines       15965    15970       +5     
==========================================
+ Hits         8352     8353       +1     
- Misses       7335     7337       +2     
- Partials      278      280       +2
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️
pkg/apis/configuration/validation/virtualserver.go 94.38% <0.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Sep 8, 2022
lucacome
lucacome approved these changes Sep 8, 2022
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR @hafe !

Would you mind adding the new parameter to our website docs here docs/content/installation/installation-with-helm.md?

@github-actions github-actions bot added documentation Pull requests/issues for documentation and removed enhancement Pull requests for new features/feature enhancements labels Sep 8, 2022
@hafe
Copy link
Contributor Author
hafe commented Sep 8, 2022

Thanks again for the PR @hafe !

Would you mind adding the new parameter to our website docs here docs/content/installation/installation-with-helm.md?

Done!

@lucacome lucacome requested a review from a team September 9, 2022 19:00
@hafe
Copy link
Contributor Author
hafe commented Sep 9, 2022

Did I do the right thing? I did rebase from main and force push.

@lucacome
Copy link
lucacome commented Sep 9, 2022

Yep @hafe I'm just waiting for a second review from the team before I merge it @nginxinc/kic

@lucacome lucacome self-assigned this Sep 9, 2022
ciarams87
ciarams87 approved these changes Sep 10, 2022
View reviewed changes
Copy link
Contributor
@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@lucacome lucacome merged commit f03f906 into nginx:main Sep 10, 2022
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

+1 more reviewer

@lucacome lucacome lucacome approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to specify image with digest in helm chart
4 participants
@hafe @codecov-commenter @lucacome @ciarams87
0