8000 fix: Correct error message on missing path in path validation by zachomedia · Pull Request #2971 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

fix: Correct error message on missing path in path validation #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2022
Merged

fix: Correct error message on missing path in path validation #2971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6174281
fix: Output the correct field path in validatePath
Aug 25, 2022
87bc1b0
docs: Document the path field is required
Aug 25, 2022
1e0078e
fix: Fix field path in documentation
zachomedia Aug 25, 2022
a8143d4
Merge branch 'main' into fix-path-validation-error
jjngx Sep 13, 2022
3440b50
Merge branch 'main' into fix-path-validation-error
lucacome Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/content/configuration/ingress-resources/basic-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Starting from Kubernetes 1.18, you can use the following new features:
The NGINX Ingress Controller imposes the following restrictions on Ingress resources:
* When defining an Ingress resource, the `host` field is required.
* The `host` value needs to be unique among all Ingress and VirtualServer resources unless the Ingress resource is a [mergeable minion](/nginx-ingress-controller/configuration/ingress-resources/cross-namespace-configuration/). See also [Handling Host and Listener Collisions](/nginx-ingress-controller/configuration/handling-host-and-listener-collisions).
* The `path` field in `spec.rules[].http.paths[]` is required.

## Advanced Configuration

Expand Down
2 changes: 1 addition & 1 deletion internal/k8s/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ func validateIngressSpec(spec *networking.IngressSpec, fieldPath *field.Path) fi
for _, path := range r.HTTP.Paths {
idxPath := idxRule.Child("http").Child("path").Index(i)

allErrs = append(allErrs, validatePath(path.Path, fieldPath)...)
allErrs = append(allErrs, validatePath(path.Path, idxPath.Child("path"))...)
allErrs = append(allErrs, validateBackend(&path.Backend, idxPath.Child("backend"))...)
}
}
Expand Down
0