8000 Update readme by shaun-nx · Pull Request #2825 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Jul 7, 2022

Proposed changes

Updates to readme for external-dns example

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 7, 2022
@shaun-nx shaun-nx marked this pull request as ready for review July 7, 2022 09:23
@shaun-nx shaun-nx requested review from jjngx, ciarams87 and haywoodsh July 7, 2022 09:23
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ciarams87 ciarams87 merged commit 8ec6e2f into main Jul 7, 2022
@ciarams87 ciarams87 deleted the external-dns-readme branch July 7, 2022 14:05
ciarams87 pushed a commit that referenced this pull request Jul 7, 2022
Co-authored-by: “shaun-nx” <“s.odonovan@f5.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0