E54B tests: Change error string check in openapi spec tests by ciarams87 · Pull Request #2794 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

tests: Change error string check in openapi spec tests #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

tests: Change error string check in openapi spec tests #2794

merged 1 commit into from
Jun 24, 2022

Conversation

ciarams87
Copy link
Contributor

Proposed changes

Kubernetes 1.24 changes some of the error messages for lists to include the index (e.g. spec.routes.action.return.code becomes spec.routes[0].action.return.code) This commit updates error message strings to be agnostic about the index.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 force-pushed the fix-tests-for-1-24 branch 6 times, most recently from 6181c4d to bd3fc65 Compare June 23, 2022 22:09
@codecov-commenter
Copy link
codecov-commenter commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #2794 (6181c4d) into main (59e4dd9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6181c4d differs from pull request most recent head 0aac3d9. Consider uploading reports for the commit 0aac3d9 to get more accurate results

@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
- Coverage   54.03%   54.02%   -0.02%     
==========================================
  Files          53       53              
  Lines       15009    15009              
==========================================
- Hits         8110     8108       -2     
- Misses       6629     6631       +2     
  Partials      270      270
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ciarams87 ciarams87 marked this pull request as ready for review June 23, 2022 23:17
@ciarams87 ciarams87 requested review from a team, lucacome, haywoodsh and shaun-nx June 23, 2022 23:17
lucacome
lucacome approved these changes Jun 24, 2022
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you gonna revert the change to the version of kind, so we keep it separate from this one?

@ciarams87 ciarams87 force-pushed the fix-tests-for-1-24 branch from bd3fc65 to 0aac3d9 Compare June 24, 2022 09:01
@ciarams87 ciarams87 force-pushed the fix-tests-for-1-24 branch from 0aac3d9 to 2c6f76a Compare June 24, 2022 13:54
@ciarams87 ciarams87 enabled auto-merge (squash) June 24, 2022 13:54
@ciarams87 ciarams87 merged commit c1581ff into main Jun 24, 2022
@ciarams87 ciarams87 deleted the fix-tests-for-1-24 branch June 24, 2022 13:57
jjngx pushed a commit that referenced this pull request Jun 24, 2022
@ciarams87 @jjngx
tests: Change error string check in openapi spec tests (#2794)
afa538c 
Change error string check in openapi spec tests
@ciarams87 ciarams87 added tests Pull requests that update tests labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

2 more reviewers

@lucacome lucacome lucacome approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @codecov-commenter @lucacome @shaun-nx
0