feat: Report Hostname in ExternalEndpoint for VS and VSR resources #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b03a3f9 to
edc8dc2
Compare
Codecov Report
@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 53.84% 53.66% -0.19%
==========================================
Files 52 52
Lines 14936 14854 -82
==========================================
- Hits 8042 7971 -71
+ Misses 6627 6619 -8
+ Partials 267 264 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
edc8dc2 to
0751766
Compare
shaun-nx
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Minor detail here. We can remove the space between the / and Hostname in this description.
There was a problem hiding this comment.
There is likely only going to be either IP or Hostname reported in the status (there may be cases where both are reported for a LoadBalancer service but I think it would be rare?) which is why I included the slash.
shaun-nx
approved these changes
Jun 22, 2022
0751766 to
6a63bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When we report the External Endpoints as part of the VS and VSR status, we only report the external LoadBalancer Ingress IP, and we don't report the Hostname (some external load balancers assign a Hostname instead of a static IP, for example AWS ELB LoadBalancers). This adds a Hostname field to the VS and VSR which will be populated when present in the LoadBalancer service. This field won't be visible by default when running a get on a VS, but the
-o wideoption will display the field.Checklist
Before creating a PR, run through this checklist and mark each as complete.