8000 Add validation to Ingress path by shaun-nx · Pull Request #2775 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add validation to Ingress path #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 21, 2022
Merged

Add validation to Ingress path #2775

merged 4 commits into from
Jun 21, 2022

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Jun 20, 2022 •
edited
Loading

Proposed changes

  • Add string validation to the path spec for the Ingress resource
  • Update unit tests to validate the type of error returned

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 20, 2022
@codecov-commenter
Copy link
codecov-commenter commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #2775 (f2a6d01) into main (efae292) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f2a6d01 differs from pull request most recent head be17e5d. Consider uploading reports for the commit be17e5d to get more accurate results

@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
+ Coverage   53.62%   53.66%   +0.03%     
==========================================
  Files          52       52              
  Lines       14842    14854      +12     
==========================================
+ Hits         7959     7971      +12     
  Misses       6619     6619              
  Partials      264      264
Impacted Files Coverage Δ
internal/k8s/validation.go 99.20% <100.00%> (+0.02%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ciarams87
ciarams87 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor
@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

jjngx
jjngx approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shaun-nx shaun-nx merged commit 48f9a8b into main Jun 21, 2022
@shaun-nx shaun-nx deleted the feature/ingress-path-validation branch June 21, 2022 11:41
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
@zachomedia zachomedia mentioned this pull request Aug 25, 2022
Merged
6 tasks
@mkoperator mkoperator mentioned this pull request Jan 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shaun-nx @codecov-commenter @ciarams87 @jjngx
0