8000 Sanitize nginx.com/jwt-token by haywoodsh · Pull Request #2774 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Sanitize nginx.com/jwt-token #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 21, 2022
Merged

Sanitize nginx.com/jwt-token #2774

merged 8 commits into from
Jun 21, 2022

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Jun 17, 2022 •
edited
Loading

Proposed changes

Sanitize nginx.com/jwt-token ingress annotation to disallow escape characters.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@haywoodsh haywoodsh force-pushed the validate-jwt-token-with-regex branch from 46342b6 to f1b6029 Compare June 17, 2022 19:29
@codecov-commenter
Copy link
codecov-commenter commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #2774 (9d128a0) into main (efae292) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   53.62%   53.62%   -0.01%     
==========================================
  Files          52       52              
  Lines       14842    14850       +8     
==========================================
+ Hits         7959     7963       +4     
- Misses       6619     6621       +2     
- Partials      264      266       +2
Impacted Files Coverage Δ
internal/k8s/validation.go 99.19% <100.00%> (+0.01%) ⬆️
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@haywoodsh haywoodsh changed the title Validate jwt token Sanitize jwt token string Jun 20, 2022
@haywoodsh haywoodsh changed the title Sanitize jwt token string Sanitize nginx.com/jwt-token Jun 20, 2022
@haywoodsh haywoodsh marked this pull request as ready for review June 20, 2022 15:40
@haywoodsh haywoodsh force-pushed the validate-jwt-token-with-regex branch from f1b6029 to 9d128a0 Compare June 20, 2022 19:24
jjngx
jjngx approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shaun-nx shaun-nx self-requested a review June 21, 2022 13:49
shaun-nx
shaun-nx suggested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor
@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs page needs toe be updated indocs/content/configuration/ingress-resources/advanced-configuration-with-annotations.md

@shaun-nx shaun-nx self-requested a review June 21, 2022 14:32
shaun-nx
shaun-nx approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor
@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved based on conversation

@haywoodsh haywoodsh force-pushed the validate-jwt-token-with-regex branch from 104d6de to 58a3d46 Compare June 21, 2022 21:37
@haywoodsh haywoodsh merged commit 816747c into main Jun 21, 2022
@haywoodsh haywoodsh deleted the validate-jwt-token-with-regex branch June 21, 2022 22:32
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Jun 30, 2022
@ciarams87 ciarams87 added enhancement Pull requests for new features/feature enhancements labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@lucacome lucacome Awaiting requested review from lucacome

@pleshakov pleshakov Awaiting requested review from pleshakov

2 more reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haywoodsh @codecov-commenter @jjngx @shaun-nx @ciarams87
0