E546 Add string validation to sticky-cookie-services annotation by shaun-nx · Pull Request #2751 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add string validation to sticky-cookie-services annotation #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2022
Merged

Add string validation to sticky-cookie-services annotation #2751

merged 6 commits into from
Jun 16, 2022

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Jun 13, 2022 •
edited
Loading

Proposed changes

This change adds string validation to the nginx.com/sticky-cookie-services annotation for the Ingress resource

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Jun 13, 2022
jjngx
jjngx approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov-commenter
Copy link
codecov-commenter commented Jun 13, 2022 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.62%. Comparing base (d66f9e8) to head (b60c94a).
Report is 2135 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/parsing_helpers.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
- Coverage   53.63%   53.62%   -0.01%     
==========================================
  Files          52       52              
  Lines       14838    14842       +4     
==========================================
+ Hits         7958     7959       +1     
- Misses       6617     6619       +2     
- Partials      263      264       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx shaun-nx merged commit ecff120 into main Jun 16, 2022
@shaun-nx shaun-nx deleted the feature/sticky-cookie-validation branch June 16, 2022 08:18
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

@lucacome lucacome Awaiting requested review from lucacome

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shaun-nx @codecov-commenter @ciarams87 @jjngx
0