10000 Add additional unit tests to confirm special characters can't be used in the lb-method annotation by shaun-nx · Pull Request #2742 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add additional unit tests to confirm special characters can't be used in the lb-method annotation #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Add additional unit tests to confirm special characters can't be used in the lb-method annotation #2742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64b4b1a
Add tests to confirm lb-method annotation does not accept special cha…
Jun 2, 2022
babffe0
Merge branch 'main' into feature/lb-method-validation
Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions internal/k8s/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,48 @@ func TestValidateNginxIngressAnnotations(t *testing.T) {
},
msg: "invalid nginx.org/lb-method annotation, nginx plus only",
},
{
annotations: map[string]string{
"nginx.org/lb-method": "least_time header;",
},
specServices: map[string]bool{},
isPlus: true,
appProtectEnabled: false,
appProtectDosEnabled: false,
internalRoutesEnabled: false,
expectedErrors: []string{
`annotations.nginx.org/lb-method: Invalid value: "least_time header;": Invalid load balancing method: "least_time header;"`,
},
msg: "invalid nginx.org/lb-method annotation",
},
{
annotations: map[string]string{
"nginx.org/lb-method": "{least_time header}",
},
specServices: map[string]bool{},
isPlus: true,
appProtectEnabled: false,
appProtectDosEnabled: false,
internalRoutesEnabled: false,
expectedErrors: []string{
`annotations.nginx.org/lb-method: Invalid value: "{least_time header}": Invalid load balancing method: "{least_time header}"`,
},
msg: "invalid nginx.org/lb-method annotation",
},
{
annotations: map[string]string{
"nginx.org/lb-method": "$least_time header",
},
specServices: map[string]bool{},
isPlus: true,
appProtectEnabled: false,
appProtectDosEnabled: false,
internalRoutesEnabled: false,
expectedErrors: []string{
`annotations.nginx.org/lb-method: Invalid value: "$least_time header": Invalid load balancing method: "$least_time header"`,
},
msg: "invalid nginx.org/lb-method annotation",
},
{
annotations: map[string]string{
"nginx.org/lb-method": "invalid_method",
Expand Down
0