Fix Dockerfile for amd64 microarchitectures #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f04162d to
b26be94
Compare
ciarams87
approved these changes
Apr 21, 2022
jjngx
approved these changes
Apr 21, 2022
shaun-nx
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoReleaser added support for microarchitectures for amd64, introduced in go
1.18.Since we build only one microarchitecture for every architecture that supports them, there's no need to specify
TARGETVARIANTfor now. Also Docker doesn't recognize amd64 microarchitectures as aTARGETVARIANT(for now?).