8000 Create -enable-oidc command line argument for OIDC policy by haywoodsh · Pull Request #2580 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Create -enable-oidc command line argument for OIDC policy #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 8, 2022
Merged

Create -enable-oidc command line argument for OIDC policy #2580

merged 9 commits into from
Apr 8, 2022

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Apr 6, 2022 •
edited
Loading

Proposed changes

Create the -enable-oidc flag command line argument for the OIDC policy and deprecate the -enable-preview-policies flag.

  • The OIDC policy requires -enable-oidc or -enable-preview-policies
  • If -enable-preview-policies is used, returns a warning message about the deprecated flag but OIDC will still be valid.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 6, 2022
@codecov-commenter
Copy link
codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #2580 (cbba097) into main (192c76f) will decrease coverage by 0.10%.
The diff coverage is 38.88%.

❗ Current head cbba097 differs from pull request most recent head d883a06. Consider uploading reports for the commit d883a06 to get more accurate results

@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   53.53%   53.43%   -0.11%     
==========================================
  Files          52       49       -3     
  Lines       14691    14304     -387     
==========================================
- Hits         7865     7643     -222     
+ Misses       6568     6418     -150     
+ Partials      258      243      -15
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.93% <0.00%> (+0.01%) ⬆️
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/k8s/controller.go 10.90% <20.00%> (+0.03%) ⬆️
internal/configs/configmaps.go 18.22% <100.00%> (ø)
pkg/apis/configuration/validation/policy.go 94.42% <100.00%> (-2.13%) ⬇️
internal/certmanager/helper.go
internal/certmanager/sync.go
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ciarams87
ciarams87 reviewed Apr 6, 2022
View reviewed changes
lucacome
lucacome reviewed Apr 6, 2022
View reviewed changes
brianehlert
brianehlert reviewed Apr 6, 2022
View reviewed changes
lucacome
lucacome approved these changes Apr 7, 2022
View reviewed changes
pleshakov
pleshakov approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few docs-related suggestion to make it consistent with the existing documentation.

@ciarams87 ciarams87 enabled auto-merge (squash) April 8, 2022 06:29
@ciarams87 ciarams87 merged commit b60f25e into main Apr 8, 2022
@ciarams87 ciarams87 deleted the new-flag branch April 8, 2022 06:32
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Apr 8, 2022
@shaun-nx shaun-nx mentioned this pull request Nov 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianehlert brianehlert brianehlert left review comments

@ciarams87 ciarams87 ciarams87 left review comments

+2 more reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haywoodsh @codecov-commenter @lucacome @pleshakov @brianehlert @ciarams87
0