8000 Add container resource requests by lucacome · Pull Request #2484 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add container resource requests #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2022
Merged

Add container resource requests #2484

merged 3 commits into from
Apr 21, 2022

Conversation

lucacome
Copy link

Adds default container resources for the Ingress Controller

@lucacome lucacome added the proposal An issue that proposes a feature request label Mar 12, 2022
@lucacome lucacome requested a review from a team March 12, 2022 02:33
@lucacome lucacome self-assigned this Mar 12, 2022
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Mar 12, 2022
@codecov-commenter
Copy link
codecov-commenter commented Mar 12, 2022 •
edited
Loading

Codecov Report

Merging #2484 (b1cbb78) into main (31d7f33) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head b1cbb78 differs from pull request most recent head 442293e. Consider uploading reports for the commit 442293e to get more accurate results

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
+ Coverage   53.43%   53.53%   +0.09%     
==========================================
  Files          52       52              
  Lines       14696    14691       -5     
==========================================
+ Hits         7853     7865      +12     
+ Misses       6581     6568      -13     
+ Partials      262      258       -4
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.91% <0.00%> (+0.05%) ⬆️
internal/k8s/configuration.go 95.86% <0.00%> (+0.38%) ⬆️
pkg/apis/configuration/validation/policy.go 96.55% <0.00%> (+2.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome
Copy link
Author
lucacome commented Apr 7, 2022

@jasonwilliams14 we noticed some problems in OpenShift without requests. But it's also a good practice to set them and minimize the chances of pod eviction (see here)

@lucacome lucacome force-pushed the feat/add-container-resources branch 2 times, most recently from edaba03 to b1cbb78 Compare April 8, 2022 00:18
@lucacome lucacome changed the title Add container resources Add container resource requests Apr 8, 2022
@lucacome lucacome force-pushed the feat/add-container-resources branch from b1cbb78 to 98e6910 Compare April 13, 2022 00:58
@lucacome lucacome merged commit 888f52c into main Apr 21, 2022
@lucacome lucacome deleted the feat/add-container-resources branch April 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov pleshakov was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements proposal An issue that proposes a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @codecov-commenter @ciarams87 @jjngx
2A98
0