Fix healthcheck ports #2378
Merged
Fix healthcheck ports #2378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff1708 to
fb7ba08
Compare
pleshakov
reviewed
Jan 25, 2022
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
4c2fbcf to
cec916e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
==========================================
+ Coverage 53.66% 53.68% +0.02%
==========================================
Files 48 48
Lines 14201 14199 -2
==========================================
+ Hits 7621 7623 +2
+ Misses 6340 6338 -2
+ Partials 240 238 -2
Continue to review full report at Codecov.
|
pleshakov
reviewed
Jan 26, 2022
cec916e to
737bf1a
Compare
737bf1a to
ed45743
Compare
pleshakov
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Don't set the upstream port as the default port for healthchecks - healthchecks will default to the port of the server instead (see https://nginx.org/en/docs/http/ngx_http_upstream_hc_module.html#health_check).
Checklist
Before creating a PR, run through this checklist and mark each as complete.