8000 api version clarification by brianehlert · Pull Request #2276 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

api version clarification #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2021
Merged

api version clarification #2276

merged 4 commits into from
Dec 20, 2021

Conversation

brianehlert
Copy link
Collaborator

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [x ] I have updated necessary documentation
  • [x ] I have rebased my branch onto master
  • [x ] I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 15, 2021
@nginx-bot nginx-bot force-pushed the brianeh-api-version-statement branch 9 times, most recently from 1223b98 to a395d78 Compare December 17, 2021 16:02
@brianehlert brianehlert requested a review from JTorreG December 17, 2021 18:17
JTorreG
JTorreG approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor
@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nginx-bot nginx-bot force-pushed the brianeh-api-version-statement branch from a395d78 to c037c15 Compare December 17, 2021 21:48
@nginx-bot nginx-bot force-pushed the brianeh-api-version-statement branch from c037c15 to da020bc Compare December 20, 2021 21:40
lucacome
lucacome reviewed Dec 20, 2021
View reviewed changes
@lucacome lucacome merged commit e8e46d2 into master Dec 20, 2021
@lucacome lucacome deleted the brianeh-api-version-statement branch December 20, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@JTorreG JTorreG JTorreG approved these changes

@tomasohaodha tomasohaodha Awaiting requested review from tomasohaodha

@travisamartin travisamartin Awaiting requested review from travisamartin

+1 more reviewer

@lucacome lucacome lucacome left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianehlert @lucacome @ciarams87 @JTorreG
0