test: fix flaky test #2247
Merged
test: fix flaky test #2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
approved these changes
Dec 7, 2021
vepatel
approved these changes
Dec 7, 2021
vepatel
reviewed
Dec 7, 2021
33b4830 to
1b32382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is a race condition getting the last log on a failed gRPC status entry (this actually generates 3 different log entries). This commit rectifies the issue by waiting until all are ready, and then checking the whole log.
Checklist
Before creating a PR, run through this checklist and mark each as complete.