8000 Fixes #2210 | enableSnippets should not depend from enableCustomResources by AlessioCasco · Pull Request #2215 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fixes #2210 | enableSnippets should not depend from enableCustomResources #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fixes #2210 | enableSnippets should not depend from enableCustomResources #2215

merged 1 commit into from
Nov 30, 2021

Conversation

AlessioCasco
Copy link
Contributor

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation | Not needed in this case
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@AlessioCasco AlessioCasco changed the title Fixes #2210 Fixes #2210 | enableSnippets should not depend from enableCustomResources Nov 25, 2021
@soneillf5 soneillf5 self-requested a review November 29, 2021 12:41
@AlessioCasco
Fixes #2210
b551c22 
* In helm, controller.enableSnippets should not depend from controller.enableCustomResources
@pleshakov pleshakov added the bug An issue reporting a potential bug label Nov 30, 2021
@soneillf5
Copy link
Contributor

@AlessioCasco Thanks for submitting this PR, we're happy to merge it once the tests pass.

@tomasohaodha tomasohaodha merged commit 0a31878 into nginx:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[helm chart] enableSnippets should not depend from enableCustomResources
4 participants
@AlessioCasco @soneillf5 @pleshakov @tomasohaodha
0