8000 Add metric about total number of TransportServers by pleshakov · Pull Request #2149 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add metric about total number of TransportServers #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2021
Merged

Add metric about total number of TransportServers #2149

merged 2 commits into from
Nov 8, 2021

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Add a new Prometheus metric about TransportServers:
controller_transportserver_resources_total. Number of handled TransportServer resources. This metric includes the label type, that groups the TransportServer resources by their type (passthrough, tcp or udp).

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Nov 1, 2021
@pleshakov pleshakov force-pushed the feature/ts-metrics branch 3 times, most recently from ffcf9f0 to 883ed69 Compare November 1, 2021 22:19
soneillf5
soneillf5 reviewed Nov 2, 2021
View reviewed changes
@nginx-bot nginx-bot force-pushed the feature/ts-metrics branch 3 times, most recently from 4916525 to ad19cdc Compare November 4, 2021 10:41
@pleshakov pleshakov requested a review from lucacome November 4, 2021 16:28
@pleshakov
Copy link
Contributor Author

@soneillf5 @lucacome the previous tests failure was cause by a bug (panic because of nil pointer). this fixes the bug -- 6b2e372

@soneillf5 soneillf5 self-requested a review November 8, 2021 17:05
@pleshakov pleshakov merged commit 933e153 into master Nov 8, 2021
@pleshakov pleshakov deleted the feature/ts-metrics branch November 8, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel Awaiting requested review from vepatel

2 more reviewers

@lucacome lucacome lucacome approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @lucacome @soneillf5
0