Update JWT library to golang-jwt/jwt #2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
approved these changes
Oct 12, 2021
soneillf5
reviewed
Oct 12, 2021
| @@ -1,4 +1,4 @@ | |||
| // +build aws | |||
| //go:build aws | |||
There was a problem hiding this comment.
which tool uses this tag? I'm not familiar with it
There was a problem hiding this comment.
it's standard go https://pkg.go.dev/cmd/go#hdr-Build_constraints. I think they changed the syntax at some point and replaced + with go:. If it wasn't for VS Code that automatically changed it, I probably wouldn't have noticed 😄
There was a problem hiding this comment.
So you can do something like go build -tags=aws github.com/nginxinc/kubernetes-ingress/cmd/nginx-ingress (and GoReleaser does the same)
soneillf5
approved these changes
Oct 12, 2021
311d64d to
8e58cd0
Compare
|
Merging this to |
lucacome
added a commit
that referenced
this pull request
Oct 14, 2021
* Update JWT library to golang-jwt/jwt (#2074) * Update packages for CVE-2021-37750 * Remove nap plus version override * Use release specific repo for NAP on Debian (#2082) * Release 2.0.2 (#2085) Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com> Co-authored-by: Luca Comellini <luca.com@gmail.com> Co-authored-by: Ciara Stacke <c.stacke@f5.com> Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com> Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dgrijalva/jwt-go is no longer maintained, the development has moved to https://github.com/golang-jwt/jwt.
This PR replaces the old library with the new one. Also added some simple unit tests for claims validation.