10BC0 Add v1alpha1 version back to policy CRD by ciarams87 · Pull Request #1956 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add v1alpha1 version back to policy CRD #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2021
Merged

Add v1alpha1 version back to policy CRD #1956

merged 3 commits into from
Sep 15, 2021

Conversation

ciarams87
Copy link
Contributor
@ciarams87 ciarams87 commented Sep 13, 2021 •
edited
Loading

Proposed changes

This commit provides a non-destructive upgrade path for policy v1alpha1 -> v1.
This is NOT re-adding support for v1alpha1, v1alpha1 is deprecated and v1 policy should be used.
v1alpha1 will be re-removed in 1.14

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 force-pushed the test-multiple-versions branch from 3ab23f9 to 9a4d8cb Compare September 14, 2021 10:31
@ciarams87 ciarams87 force-pushed the test-multiple-versions branch from 9a4d8cb to a28cd30 Compare September 14, 2021 11:47
@ciarams87 ciarams87 marked this pull request as ready for review September 14, 2021 11:47
@ciarams87 ciarams87 enabled auto-merge (squash) September 15, 2021 10:30
@ciarams87 ciarams87 merged commit f423b22 into master Sep 15, 2021
@ciarams87 ciarams87 deleted the test-multiple-versions branch September 15, 2021 10:33
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Sep 22, 2021
@vepatel vepatel mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome Awaiting requested review from lucacome

@vepatel vepatel Awaiting requested review from vepatel

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @pleshakov @soneillf5 @nginx-bot
0