10000 Add logs around NGINX Plus binary/flag mismatch by lucacome · Pull Request #1494 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add logs around NGINX Plus binary/flag mismatch #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Add logs around NGINX Plus binary/flag mismatch #1494

merged 1 commit into from
Apr 2, 2021

Conversation

lucacome
Copy link
@lucacome lucacome commented Apr 2, 2021
  • New function to get NGINX version
  • Check that NGINX version and flag match

@lucacome lucacome requested a review from a team April 2, 2021 00:16
@lucacome lucacome self-assigned this Apr 2, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team April 2, 2021 00:16
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Apr 2, 2021
soneillf5
soneillf5 reviewed Apr 2, 2021
View reviewed changes
cmd/nginx-ingress/main.go
isPlus := strings.Contains(nginxVersion, "plus")
glog.Infof("Using %s", nginxVersion)

if *nginxPlus && !isPlus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! This has caught me out when I started KIC and I've seen it reported in slack.

@lucacome lucacome merged commit 86cbd89 into master Apr 2, 2021
@lucacome lucacome deleted the feat/improve-plus-message branch April 2, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

+1 more reviewer

@soneillf5 soneillf5 soneillf5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @ciarams87 @soneillf5
0