Add serverSnippets to TransportServer #1413
Conversation
There was a problem hiding this comment.
8000
Shall we also add streamSnippets field that configures snippets in the stream context ? similar to http-snippets https://deploy-preview-1413--nginx-kubernetes-ingress.netlify.app/nginx-ingress-controller/configuration/virtualserver-and-virtualserverroute-resources/#using-snippets
I agree - there are some directives that can only be specified at the |
d38bed9 to
6f00de0
Compare
|
the changes look good to me. However, because of the future streamSnippets, we need to rename apiVersion: k8s.nginx.org/v1alpha1
kind: TransportServer
metadata:
name: dns-tcp
spec:
streamSnippets: |
limit_conn_zone $binary_remote_addr zone=addr:10m;
listener:
name: dns-tcp
protocol: TCP
serverSnippets: |
limit_conn addr 1;
limit_conn_log_level error;
upstreams:
- name: dns-app
service: coredns
port: 5353
action:
pass: dns-app |
There was a problem hiding this comment.
@soneillf5
the last change looks good! however, because of the change, there is some remaining code and logic, which is not really used - that's why a few comments below
Proposed changes
This PR adds Snippet feature to the TransportServer resource.
Checklist
Before creating a PR, run through this checklist and mark each as complete.