8000 Add passive health checks to TransportServer by LorcanMcVeigh · Pull Request #1382 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add passive health checks to TransportServer #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2021
Merged

Add passive health checks to TransportServer #1382

merged 2 commits into from
Feb 18, 2021

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

Add new parameters to upstream server to allow for passive health checks

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Feb 16, 2021
pleshakov
pleshakov reviewed Feb 16, 2021
View reviewed changes
8000
@LorcanMcVeigh LorcanMcVeigh removed the request for review from soneillf5 February 18, 2021 10:48
@LorcanMcVeigh LorcanMcVeigh merged commit 33b0bb5 into master Feb 18, 2021
@LorcanMcVeigh LorcanMcVeigh deleted the passive-hc branch February 18, 2021 10:49
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Feb 19, 2021
@pleshakov pleshakov changed the title Add passive health checks to transportServer Add passive health checks to TransportServer Mar 16, 2021
Sign up for free to join this conversation on GitHub. A 7EC8 lready have an account? Sign in to comment
Reviewers

@lucacome lucacome Awaiting requested review from lucacome

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@LorcanMcVeigh LorcanMcVeigh

@soneillf5 soneillf5

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LorcanMcVeigh @pleshakov @Dean-Coakley @lucacome @soneillf5
0