8000 Improve VirtualServer/VirtualServerRoute warnings for policies by pleshakov · Pull Request #1322 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Improve VirtualServer/VirtualServerRoute warnings for policies #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2021
Merged

Improve VirtualServer/VirtualServerRoute warnings for policies #1322

merged 4 commits into from
Jan 29, 2021

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Improve VS/VSR warnings for policies:

  • Ensure that the policy ns/name is always mentioned
  • Ensure that the secret ns/name is always mentioned
  • If there is a secret mismatch, mention what type is required
  • Enclose field values in ''
    For example, Configuration for default/webapp was added or updated ; with warning(s): JWT policy default/jwt-policy references a secret default/cafe-secret of a wrong type 'kubernetes.io/tls', must be 'nginx.org/jwk'

Additionally, the PR removes unreachable warnings-related code and adds a missing test case.

@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jan 22, 2021
@pleshakov pleshakov merged commit 42563af into master Jan 29, 2021
@pleshakov pleshakov deleted the improve-warnings branch January 29, 2021 02:02
@pleshakov pleshakov changed the title Improve VS/VSR warnings for policies Improve VirtualServer/VirtualServerRoute warnings for policies Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucacome lucacome lucacome approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @lucacome @LorcanMcVeigh
0