8000 Update documentation for ingress annotation validation by mikestephen · Pull Request #1293 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update documentation for ingress annotation validation #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2021
Merged

Update documentation for ingress annotation validation #1293

merged 3 commits into from
Jan 4, 2021

Conversation

mikestephen
Copy link

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label Dec 18, 2020
jputrino
jputrino approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor
@jputrino jputrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jputrino
Update docs-web/configuration/ingress-resources/advanced-configuratio…
fafa990 
…n-with-annotations.md

Co-authored-by: Jodie Putrino <j.putrino@f5.com>
@mikestephen mikestephen merged commit 43826b0 into master Jan 4, 2021
@mikestephen mikestephen deleted the update-annotation-validation-docs branch January 18, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jputrino jputrino jputrino approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

@pleshakov pleshakov Awaiting requested review from pleshakov

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikestephen @pleshakov @jputrino @Dean-Coakley
0