8000 Remove/Deprecate support for helm2 clients by Dean-Coakley · Pull Request #1237 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Remove/Deprecate support for helm2 clients #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2020
Merged

Remove/Deprecate support for helm2 clients #1237

merged 5 commits into from
Nov 19, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Helm2 has been deprecated so we no longer need to support it: https://helm.sh/blog/helm-2-becomes-unsupported/

  • Remove references to helm2 instructions from docs.
  • Remove Kubernetes 1.14 specific notes as it is no longer supported.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork< 8000 /li>

@Dean-Coakley
Remove support for helm2 clients
93da692 
Helm2 has been deprecated so we no longer need to support it.
@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label Nov 18, 2020
@Dean-Coakley Dean-Coakley self-assigned this Nov 18, 2020
Dean-Coakley
Dean-Coakley commented Nov 18, 2020
View reviewed changes
pleshakov
pleshakov approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Dean-Coakley
Dean-Coakley commented Nov 19, 2020
View reviewed changes
@Dean-Coakley Dean-Coakley merged commit 6d531e2 into master Nov 19, 2020
@Dean-Coakley Dean-Coakley deleted the deprecate-helm2 branch November 19, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

2 more reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @lucacome @pleshakov
0