10BC0 Add support for EgressMTLS by lucacome · Pull Request #1180 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add support for EgressMTLS #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 9, 2020
Merged

Add support for EgressMTLS #1180

merged 9 commits into from
Oct 9, 2020

Conversation

lucacome
Copy link
@lucacome lucacome commented Oct 8, 2020

Adding support for Egress MTLS. Docs will come in another PR.

LorcanMcVeigh
LorcanMcVeigh approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor
@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, just spotted this because of the linter

pleshakov
pleshakov suggested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucacome

Please see my comments and suggestions.

lucacome and others added 2 commits October 8, 2020 13:11
@lucacome @pleshakov @LorcanMcVeigh
Apply suggestions from code review
028f118 
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
Co-authored-by: Lorcan McVeigh <lorcan.mcveigh@gmail.com>
@lucacome
PR feedback
262aee3
@lucacome lucacome requested a review from pleshakov October 9, 2020 06:21
pleshakov
pleshakov reviewed Oct 9, 2020
View reviewed changes
lucacome and others added 2 commits October 9, 2020 12:23
@lucacome
PR feedback
3ee836a
@lucacome @pleshakov
Update examples-of-custom-resources/egress-mtls/README.md
75493a9 
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
@lucacome lucacome requested a review from pleshakov October 9, 2020 19:24
pleshakov
pleshakov approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucacome lucacome merged commit 2fcf6c1 into master Oct 9, 2020
@lucacome lucacome deleted the egress-mtls branch October 9, 2020 21:29
@lucacome lucacome self-assigned this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @LorcanMcVeigh
0