E5F8 Add pod_owner label to metrics when -spire-agent-address is set by kate-osborn · Pull Request #1137 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add pod_owner label to metrics when -spire-agent-address is set #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

Add pod_owner label to metrics when -spire-agent-address is set #1137

merged 1 commit into from
Sep 11, 2020
+220 −39

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

NGINX Service Mesh needs to know the owner kind and name of the pod in order to produce metrics according to the smi-spec. This PR adds a pod_owner label to metrics when the -spire-agent-address is set. The metrics produced by the mesh only support owner types of Deployment, StatefulSet, and DaemonSet. If the owner type is not one of these resources we default to deployment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

pleshakov
pleshakov approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lucacome
lucacome approved these changes Sep 10, 2020
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kate-osborn kate-osborn merged commit d7d4b74 into master Sep 11, 2020
@kate-osborn kate-osborn deleted the mesh-pod-owner branch September 11, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kate-osborn @lucacome @pleshakov
0