8000 Make installing CRDs via kubectl a prerequisite for helm2 clients by Dean-Coakley · Pull Request #1047 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Make installing CRDs via kubectl a prerequisite for helm2 clients #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

Make installing CRDs via kubectl a prerequisite for helm2 clients #1047

merged 2 commits into from
Jul 10, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Installing CRDs is now a prerequisite to installing the chart via helm2 clients.
  • Helm chart no longer installs CRDs when using helm2.x client. crd-install hooks have been removed.
  • General docs structure improvements.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label Jul 9, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jul 9, 2020
@pleshakov pleshakov added the change Pull requests that introduce a change label Jul 9, 2020
pleshakov
pleshakov approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley looks good!
Please implement a suggestion before merging.

@Dean-Coakley
Fix reinstall CRDs via helm2 clients
0d20071 
Installing CRDs is now a prerequisite to installing the chart via helm2
clients.
Also included general docs structure improvements.
@Dean-Coakley
Move add helm repo instructions outside of install doc
fb3a8fa
@Dean-Coakley Dean-Coakley merged commit 40df4d4 into master Jul 10, 2020
@Dean-Coakley Dean-Coakley deleted the helm2-crd-fix branch July 10, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

2 more reviewers

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
change Pull requests that introduce a change documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @lucacome @pleshakov
0