8000 Fix VirtualServer location snippets by Dean-Coakley · Pull Request #1031 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fix VirtualServer location snippets #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Fix VirtualServer location snippets #1031

merged 1 commit into from
Jul 2, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the bug An issue reporting a potential bug label Jul 2, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jul 2, 2020
@Dean-Coakley Dean-Coakley merged commit 67fa84e into master Jul 2, 2020
@Dean-Coakley Dean-Coakley deleted the fix-vs-vsr-snippets branch July 2, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Rulox Rulox Rulox approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @Rulox @LorcanMcVeigh
0