8000 Fix multiple KIC releases in helm by Dean-Coakley · Pull Request #1009 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fix multiple KIC releases in helm #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 1, 2020
Merged

Fix multiple KIC releases in helm #1009

merged 6 commits into from
Jul 1, 2020

Conversation

Dean-Coakley
Copy link
Contributor
@Dean-Coakley Dean-Coakley commented Jun 23, 2020 •
edited
Loading

Proposed changes

Fixes: #967
Fixes: #950

Allows multiple installs of the Ingress Controller to be installed in the same cluster.

Behaviour changes

Upgrades

Upgrade path with controller.enableCustomResources=true

  • Given a deployed 1.7.x IC

  • helm upgrade my-release deployments/helm-chart

    Note: Existing CRDs and CRs will be deleted. You will also see listers temporarily fail until CRDs are recreated.

  • Recreate CRDs
    • kubectl apply -f deployments/helm-chart/crds
  • Recreate CRs.

Upgrade path with controller.enableCustomResources=false

  • Given a deployed 1.7.x IC

  • helm upgrade my-release deployments/helm-chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added enhancement Pull requests for new features/feature enhancements change Pull requests that introduce a change labels Jun 23, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jun 23, 2020
@Rulox
Copy link
Contributor
Rulox commented Jun 25, 2020

Looks good. I am a little bit worried by:
Note: Existing CRDs and CRs will be deleted. You will also see listers temporarily fail until CRDs are recreated.

I guess we'll have to document this very carefully on the new Release Notes.

Rulox
Rulox approved these changes Jun 25, 2020
View reviewed changes
pleshakov
pleshakov reviewed Jun 25, 2020
View reviewed changes
@Dean-Coakley Dean-Coakley force-pushed the fix-helm-chart-crds branch from ab8e26f to aee0168 Compare June 29, 2020 12:48
@Dean-Coakley Dean-Coakley requested a review from pleshakov June 30, 2020 15:32
pleshakov
pleshakov approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley lgtm!

this doc https://github.com/nginxinc/kubernetes-ingress/blob/master/docs-web/installation/installation-with-helm.md needs to be updated as well before merging

@Rulox Rulox mentioned this pull request Jul 1, 2020
Closed
6 tasks
@Dean-Coakley Dean-Coakley merged commit 5b354eb into master Jul 1, 2020
@Dean-Coakley Dean-Coakley deleted the fix-helm-chart-crds branch July 1, 2020 11:12
@pleshakov pleshakov changed the title Fix multiple KIC deploys via helm Fix multiple KIC releases via helm Jul 8, 2020
@pleshakov pleshakov changed the title Fix multiple KIC releases via helm Fix multiple KIC releases in helm Jul 8, 2020
@pleshakov pleshakov added the bug An issue reporting a potential bug label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

3 more reviewers

@Rulox Rulox Rulox approved these changes

@lucacome lucacome lucacome approved these changes

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
bug An issue reporting a potential bug change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm 3 multiple ingress controller install results in CRD conflict [Helm] Trying to install a second release
4 participants
@Dean-Coakley @Rulox @lucacome @pleshakov
0