8000 Refactor HTTP Proxy module by alessfg · Pull Request #87 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Refactor HTTP Proxy module #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2021
Merged

Refactor HTTP Proxy module #87

merged 1 commit into from
Mar 2, 2021

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Mar 2, 2021 •
edited
Loading

Proposed changes

Refactor the proxy HTTP config template into its own separate file. All variables have changed (check defaults/main/template.yml for examples):

  • All proxy_* related variables now live under the proxy dictionary key, with the exception of proxy_pass and proxy_cache_path. You can specify the proxy dictionary key inside the http, server, and location contexts.
  • Remove the nginx_config_main_template.http_settings.cache dictionary variable. Use nginx_config_http_template.*.proxy_cache_path instead.
  • Remove the location.websocket variable. Use location.proxy.set_header instead:
proxy:
  set_header:
    - field: Upgrade
      value: $http_upgrade
    - field: Connection
      value: Upgrade

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Mar 2, 2021
@alessfg alessfg added the breaking change Implies a breaking change label Mar 2, 2021
@alessfg alessfg added this to the 0.4.0 milestone Mar 2, 2021
@alessfg alessfg merged commit 4269a22 into main Mar 2, 2021
@alessfg alessfg deleted the refactor-http-proxy branch March 2, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
breaking change Implies a breaking change
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg
0