8000 Change directory to `/etc/nginx` before running NGINX config check by aknot242 · Pull Request #81 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Change directory to /etc/nginx before running NGINX config check #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2021
Merged

Change directory to /etc/nginx before running NGINX config check #81

merged 2 commits into from
Feb 19, 2021

Conversation

aknot242
Copy link
Contributor
@aknot242 aknot242 commented Feb 19, 2021 •
edited by alessfg
Loading

Proposed changes

In App Protect environments on SELinux enforced systems, the nginx -t handler fails when run from a directory that the nginx process' user does not have access to. Fix: cd to etc nginx before running test command.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@aknot242 aknot242 requested a review from alessfg February 19, 2021 01:15
@alessfg alessfg added the bug Something isn't working label Feb 19, 2021
@alessfg alessfg added this to the 0.4.0 milestone Feb 19, 2021
@alessfg alessfg changed the title cd to etc nginx before running test command Change directory to /etc/nginx before running NGINX config check Feb 19, 2021
@alessfg alessfg merged commit a156d8d into main Feb 19, 2021
@alessfg alessfg deleted the nap-nginx-test-fix branch February 19, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessfg alessfg Awaiting requested review from alessfg

Assignees

@aknot242 aknot242

Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aknot242 @alessfg
0