8000 Refactor NGINX config uploads by alessfg · Pull Request #79 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Refactor NGINX config uploads #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2021
Merged

Refactor NGINX config uploads #79

merged 3 commits into from
Feb 16, 2021

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Feb 16, 2021 •
edited
Loading

Proposed changes

  • Rename upload related variables:
    • Rename the nginx_config_snippet_upload_* parameters to nginx_config_upload_* (check defaults/main/upload.yml for an example).
    • Rename the nginx_config_html_upload_* parameters to nginx_config_upload_html_*.
    • Rename the nginx_config_ssl_upload_* parameters to nginx_config_upload_ssl_*.
  • Tweak the nginx_config_html_upload and nginx_config_ssl_upload parameters to now use a list instead of a single src and dest value (check defaults/main/upload.yml for an example).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Feb 16, 2021
@alessfg alessfg added breaking change Implies a breaking change enhancement Enhance an existing feature labels Feb 16, 2021
@alessfg alessfg added this to the 0.4.0 milestone Feb 16, 2021
@alessfg alessfg merged commit 3d6b859 into main Feb 16, 2021
@alessfg alessfg deleted the refactor-uploads branch February 16, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
breaking change Implies a breaking change enhancement Enhance an existing feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg
0