8000 Skip GH action *plus* tests only when secrets aren't present by alessfg · Pull Request #271 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Skip GH action *plus* tests only when secrets aren't present #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Skip GH action *plus* tests only when secrets aren't present #271

merged 1 commit into from
Sep 9, 2022

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Sep 8, 2022 •
edited
Loading

Proposed changes

Update GitHub actions to only skip plus scenarios when the NGINX Plus license secrets are not present (it used to only run the NGINX Plus test scenarios during internal PRs).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg
Skip GH action *plus* tests only when secrets aren't present
31bb4b1 
Update GitHub actions to only skip *plus* scenarios when the NGINX Plus license secrets are not present (it used to only run the NGINX Plus test scenarios during internal PRs).
@alessfg alessfg self-assigned this Sep 8, 2022
@alessfg alessfg added the tests Improvements to tests label Sep 8, 2022
@alessfg alessfg added this to the 0.5.2 milestone Sep 8, 2022
@alessfg alessfg merged commit 5f595da into main Sep 9, 2022
@alessfg alessfg deleted the update-github-actions branch September 9, 2022 16:30
alessfg added a commit that referenced this pull request Sep 9, 2022
@alessfg
Skip GH action *plus* tests only when secrets aren't present (#271)
7e8817b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
tests Improvements to tests
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg
0