8000 Additional Jinja2 sequence/mapping fixes by alessfg · Pull Request #194 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Additional Jinja2 sequence/mapping fixes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Additional Jinja2 sequence/mapping fixes #194

merged 1 commit into from
Oct 28, 2021

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Oct 28, 2021 •
edited
Loading

Proposed changes

Some Jinja2 sequence changes were missed in #191. This PR addresses the missing scenarios.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Oct 28, 2021
@alessfg alessfg added the bug Something isn't working label Oct 28, 2021
@alessfg alessfg added this to the 0.4.2 milestone Oct 28, 2021
@github-actions github-actions bot added the enhancement Enhance an existing feature label Oct 28, 2021
tcraxs
tcraxs approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor
@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessfg alessfg merged commit b862b71 into main Oct 28, 2021
@alessfg alessfg deleted the minor-sequence-fixes branch October 28, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tcraxs tcraxs tcraxs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@alessfg alessfg

Labels
bug Something isn't working enhancement Enhance an existing feature
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@alessfg @tcraxs
0