8000 Fix `deployment_location` directory not being created by alessfg · Pull Request #187 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Fix deployment_location directory not being created #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2021
Merged

Fix deployment_location directory not being created #187

merged 2 commits into from
Oct 23, 2021

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Oct 23, 2021 •
edited
Loading

Proposed changes

Fix issue where your deployment_location directory would not be properly created due to an outdated variable. Fixes #186.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Oct 23, 2021
@alessfg alessfg added the bug Something isn't working label Oct 23, 2021
@alessfg alessfg added this to the 0.4.1 milestone Oct 23, 2021
@alessfg alessfg merged commit 01d045b into main Oct 23, 2021
@alessfg alessfg deleted the fix-directory-not-being-created branch October 23, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignee 5625 s

@alessfg alessfg

Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

deployment_location functionality appears to be incomplete
1 participant
@alessfg
0