8000 Replace "yes"/"no" boolean values with "true"/"false" by alessfg · Pull Request #137 · nginx/ansible-role-nginx-config · GitHub
[go: up one dir, main page]
Skip to content

Replace "yes"/"no" boolean values with "true"/"false" #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2021
Merged

Replace "yes"/"no" boolean values with "true"/"false" #137

merged 1 commit into from
Jun 2, 2021

Conversation

alessfg
Copy link
Member
@alessfg alessfg commented Jun 2, 2021 •
edited
Loading

Proposed changes

Replace "yes"/"no" boolean values with "true"/"false" to comply with YAML spec 1.2.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jun 2, 2021
@alessfg alessfg added the enhancement Enhance an existing feature label Jun 2, 2021
@alessfg alessfg added this to the 0.4.0 milestone Jun 2, 2021
aknot242
aknot242 approved these changes Jun 2, 2021
View reviewed changes
.github/workflows/galaxy.yml
---
name: Ansible Galaxy import
on:
"on":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these quoted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the linter interpreting them as truthy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

@alessfg alessfg merged commit a550ef9 into main Jun 2, 2021
@alessfg alessfg deleted the replace-boolean-values-by-truthy-values branch June 2, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aknot242 aknot242 aknot242 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@alessfg alessfg

Labels
enhancement Enhance an existing feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alessfg @aknot242
0