E5FD Uncommented nolintlint, now comment is a must while adding a nolint directive. by Akshay2191 · Pull Request #1215 · nginx/agent · GitHub
[go: up one dir, main page]
Skip to content

Uncommented nolintlint, now comment is a must while adding a nolint directive. #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2025
Merged

Uncommented nolintlint, now comment is a must while adding a nolint directive. #1215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb3deab
adding lint comments
Akshay2191 Aug 15, 2025
5832e68
added test file
Akshay2191 Aug 15, 2025
8965ed4
fixing lint error in mockcollector
Akshay2191 Aug 15, 2025
f25ca7e
worked on PR review comments
Akshay2191 Aug 18, 2025
fa0d157
resolving merge conflict
Akshay2191 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
worked on PR review comments
  • Loading branch information
@Akshay2191
Akshay2191 committed Aug 18, 2025
commit f25ca7eb8130780a02fb4c8d8d4ce857bbb54c0a
2 changes: 1 addition & 1 deletion internal/collector/nginxossreceiver/internal/scraper/accesslog/nginx_log_scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func (nls *NginxLogScraper) ID() component.ID {
return component.NewID(metadata.Type)
}

//nolint:unparam //// Result is always nil
//nolint:unparam // Result is always nil
func (nls *NginxLogScraper) Start(parentCtx context.Context, _ component.Host) error {
nls.logger.Info("NGINX access log scraper started")
ctx, cancel := context.WithCancel(parentCtx)
Expand Down
2 changes: 1 addition & 1 deletion pkg/files/file_stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

var letters = []byte("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")

//nolint:gosec // random number generater if fine for test case.
//nolint:gosec // random number generater is fine for test case.
func randBytes(n int) []byte {
b := make([]byte, n)
for i := range b {
Expand Down
2 changes: 1 addition & 1 deletion test/integration/utils/grpc_management_plane_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func SetupConnectionTest(tb testing.TB, expectNoErrorsInLogs, nginxless, auxilia

// setupContainerEnvironment sets up the container environment for testing.
//
//nolint:revive // flag is required for container
//nolint:revive // "auxiliaryServer" flag is required for container
func setupContainerEnvironment(ctx context.Context, tb testing.TB, nginxless, auxiliaryServer bool,
agentConfig string,
) {
Expand Down
2 changes: 1 addition & 1 deletion test/model/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func ConfigContext() *model.NginxConfigContext {
}
}

//nolint:revive // all the aruments are necessary.
//nolint:revive // all the arguments are necessary.
func ConfigContextWithNames(
accessLogName,
combinedAccessLogName,
Expand Down
Loading
0